Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 8887001: Remove custom Task implementations and re-exorcise old callbacks from gpu. (Closed)

Created:
9 years ago by dcheng
Modified:
9 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Remove custom Task implementations and re-exorcise old callbacks from gpu. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113924

Patch Set 1 #

Patch Set 2 : base::IgnoreResult instead of base::IgnoreReturn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -194 lines) Patch
M content/browser/gpu/gpu_process_host.h View 5 chunks +12 lines, -13 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 15 chunks +28 lines, -45 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 5 chunks +17 lines, -33 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 4 chunks +48 lines, -90 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
Can you confirm that we want to ignore the result of GpuProcessHostUIShim::Create in gpu_process_host.cc:267-268? From ...
9 years ago (2011-12-08 01:28:34 UTC) #1
apatrick_chromium
Sorry, thought I LGTMed this already. LGTM. Ignoring GpuProcessHostUIShim's result is weird but I think ...
9 years ago (2011-12-09 19:35:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8887001/3001
9 years ago (2011-12-09 23:24:44 UTC) #3
commit-bot: I haz the power
Presubmit check for 8887001-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-09 23:24:50 UTC) #4
dcheng
Adding sky for OWNERS review.
9 years ago (2011-12-09 23:27:13 UTC) #5
sky
LGTM
9 years ago (2011-12-09 23:55:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8887001/3001
9 years ago (2011-12-10 00:24:18 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-10 02:07:18 UTC) #8
Change committed as 113924

Powered by Google App Engine
This is Rietveld 408576698