Add command-line option for Virtual Me2Me to set the desktop size.

Add command-line option for Virtual Me2Me to set the desktop size.


BUG=106932
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114274

[Wez, 2011-12-09 23:51:16]

LGTM, but I wonder whether we [also] want a way to pass arbitrary command-line
options to the X server, e.g. to enable/disable specific extensions, as well?

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:278: help="size of virtual desktop
(default: %default)")
nit: Would "geometry" be the more X11-ish name?

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:278: help="size of virtual desktop
(default: %default)")
nit: "size of virtual desktop" -> "dimensions of virtual desktop"

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:292: parser.error("Width/Height must be
positive numbers")
nit: You could move this test inside the try and have it throw a ValueError, and
change the parser.error() for the exception to "... must be positive numbers".

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:292: parser.error("Width/Height must be
positive numbers")
nit: It may make sense to prohibit too-small desktops, as well, as a
sanity-check against typos.

[Lambros, 2011-12-13 01:32:22]

PTAL

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:278: help="size of virtual desktop
(default: %default)")
On 2011/12/09 23:51:16, Wez wrote:
> nit: Would "geometry" be the more X11-ish name?
Nah.  xrandr uses '-s' and '--size', and calls it "size" in its manpage.  Also,
"geometry" might imply we accept XParseGeometry() formats, such as 10x20+30-40. 
I've gone with "dimensions" in the help text.

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:292: parser.error("Width/Height must be
positive numbers")
On 2011/12/09 23:51:16, Wez wrote:
> nit: You could move this test inside the try and have it throw a ValueError,
and
> change the parser.error() for the exception to "... must be positive numbers".

Done.

http://codereview.chromium.org/8885030/diff/1/remoting/tools/me2me_virtual_ho...
remoting/tools/me2me_virtual_host.py:292: parser.error("Width/Height must be
positive numbers")
On 2011/12/09 23:51:16, Wez wrote:
> nit: It may make sense to prohibit too-small desktops, as well, as a
> sanity-check against typos.

Done.

[Wez, 2011-12-13 01:43:52]

I notice you ignore my comment about passing arbitrary command-line options. ;)

Still LGTM!

http://codereview.chromium.org/8885030/diff/4001/remoting/tools/me2me_virtual...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/8885030/diff/4001/remoting/tools/me2me_virtual...
remoting/tools/me2me_virtual_host.py:299: parser.error("Dimensions should be 100
pixels or greater")
nit: I'd actually use "Width and height" rather than "Dimensions" here.

[Lambros, 2011-12-13 19:08:55]

Quite simple to add Xorg arguments, so I did it :)  PTAL

[Wez, 2011-12-13 21:17:47]

lgtm