Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: chrome/common/extensions/extension_messages.cc

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more minor sprucing Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/url_pattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_messages.cc
diff --git a/chrome/common/extensions/extension_messages.cc b/chrome/common/extensions/extension_messages.cc
index 3adee275ef648fa98c1cdea8704b546dcc2c5c6b..6a6aa20200ff7d239449a5124ba568a78a6fca99 100644
--- a/chrome/common/extensions/extension_messages.cc
+++ b/chrome/common/extensions/extension_messages.cc
@@ -116,8 +116,9 @@ bool ParamTraits<URLPattern>::Read(const Message* m, void** iter,
// match the invalid patterns. We get around this by setting the valid
// schemes after parsing the pattern. Update these method calls once we can
// ignore scheme validation with URLPattern parse options. crbug.com/90544
+ p->SetParseOption(URLPattern::IGNORE_PORTS);
p->SetValidSchemes(URLPattern::SCHEME_ALL);
- URLPattern::ParseResult result = p->Parse(spec, URLPattern::IGNORE_PORTS);
+ URLPattern::ParseResult result = p->Parse(spec);
p->SetValidSchemes(valid_schemes);
return URLPattern::PARSE_SUCCESS == result;
}
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/url_pattern.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698