Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 8885019: Fix 2 panel overflow related bugs on Windows. (Closed)

Created:
9 years ago by jianli
Modified:
9 years ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt
Visibility:
Public.

Description

Fix 2 panel overflow related bugs on Windows. 1) Bug 106880: Creating more than 6 overflow panels or closing the 6th overflow panel triggers assert on debug version 2) Bug 106882: Hovering the mouse over the top of the overflow panels may expand the overflow panels BUG=106880, 106882 TEST=Manul test by following repro steps as in bugs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113663

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix trybot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/panels/panel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_overflow_strip.cc View 1 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jianli
9 years ago (2011-12-08 19:48:14 UTC) #1
jennb
9 years ago (2011-12-08 20:05:46 UTC) #2
LGTM

http://codereview.chromium.org/8885019/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_manager.cc (right):

http://codereview.chromium.org/8885019/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_manager.cc:21: const int kOverflowStripThickness
= 26;
How is this change related to the bug fixes?

http://codereview.chromium.org/8885019/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_overflow_strip.cc (right):

http://codereview.chromium.org/8885019/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_overflow_strip.cc:105: if (panels_.empty() ||
start_index == panels_.size())
Sufficient to just check start_index >= end_index?

Powered by Google App Engine
This is Rietveld 408576698