GTK: Even more changes from raw allocation access to gtk_widget_get_allocation().

GTK: Even more changes from raw allocation access to gtk_widget_get_allocation().

BUG=79722
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113698

[Elliot Glaysher, 2011-12-08 18:53:47]

(Trying to keep these patches small so any accidental regressions can be spotted
easily.)

[Lei Zhang, 2011-12-08 20:50:30]

LGTM with a couple small comments below.

Also, I like small patches.

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/download/...
File chrome/browser/ui/gtk/download/download_item_gtk.cc (right):

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/download/...
chrome/browser/ui/gtk/download/download_item_gtk.cc:739: &left_clip, widget,
"button",
Is it ok to pass in a GtkAllocation instead of a GdkRectangle? If yes, then
ignore this.

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/infobars/...
File chrome/browser/ui/gtk/infobars/infobar_gtk.cc (right):

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/infobars/...
chrome/browser/ui/gtk/infobars/infobar_gtk.cc:243: int y = allocation.height;
you can just get rid of |y| and use |height| instead.

[Elliot Glaysher, 2011-12-08 20:56:41]

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/download/...
File chrome/browser/ui/gtk/download/download_item_gtk.cc (right):

http://codereview.chromium.org/8885016/diff/1/chrome/browser/ui/gtk/download/...
chrome/browser/ui/gtk/download/download_item_gtk.cc:739: &left_clip, widget,
"button",
On 2011/12/08 20:50:30, Lei Zhang wrote:
> Is it ok to pass in a GtkAllocation instead of a GdkRectangle? If yes, then
> ignore this.

they are typedefs

[commit-bot: I haz the power, 2011-12-08 20:57:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8885016/2002

[commit-bot: I haz the power, 2011-12-08 23:49:24]

Change committed as 113698