Issue 8885009: Revert r112160 ("Send one WebKeyboardEvent to the RenderWidget at a time.")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8885009: Revert r112160 ("Send one WebKeyboardEvent to the RenderWidget at a time.") (Closed)

Created:
9 years ago by apavlov

Modified:
9 years ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r112160 ("Send one WebKeyboardEvent to the RenderWidget at a time.") This change has resulted in severe regressions in keyboard event dispatching - the keydown and keypress events are no longer dispatched synchronously. Reverting as suggested by Darin Fisher. BUG=106224 TEST=manual TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113603

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -124 lines)			Patch
M	content/browser/renderer_host/render_widget_host.h	View	4 chunks	+14 lines, -30 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host.cc	View	9 chunks	+61 lines, -91 lines	0 comments	Download
M	content/common/view_messages.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	content/renderer/render_widget.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	3 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/8885009/1

9 years ago (2011-12-08 14:08:08 UTC) #1

Change committed as 113603

Expand Messages | Collapse Messages