Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 8885003: Fix webgl conformance test list generation script. (Closed)

Created:
9 years ago by Zhenyao Mo
Modified:
9 years ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix webgl conformance test list generation script. The current code is for update time run, so it can generate correct list per OS. However, we changed it to run locally and check the generated list in, so we need to have OS conditions for tests. Also, add DEBUG/RELEASE modifier so we can mark test failures better. BUG= TEST=gpu_tests built R=kbr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114078

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -29 lines) Patch
M chrome/test/gpu/generate_webgl_conformance_test_list.py View 1 2 chunks +54 lines, -25 lines 0 comments Download
M chrome/test/gpu/webgl_conformance_test_expectations.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/webgl_conformance_test_list_autogen.h View 1 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Ken, can you review this? Tested locally on my linux bot.
9 years ago (2011-12-08 02:18:28 UTC) #1
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/8885003/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py File chrome/test/gpu/generate_webgl_conformance_test_list.py (right): http://codereview.chromium.org/8885003/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py#newcode80 chrome/test/gpu/generate_webgl_conformance_test_list.py:80: rt = '(' + rt + ') and ' ...
9 years ago (2011-12-08 23:36:25 UTC) #2
Zhenyao Mo
http://codereview.chromium.org/8885003/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py File chrome/test/gpu/generate_webgl_conformance_test_list.py (right): http://codereview.chromium.org/8885003/diff/3001/chrome/test/gpu/generate_webgl_conformance_test_list.py#newcode80 chrome/test/gpu/generate_webgl_conformance_test_list.py:80: rt = '(' + rt + ') and ' ...
9 years ago (2011-12-09 19:21:39 UTC) #3
Ken Russell (switch to Gerrit)
9 years ago (2011-12-12 20:57:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698