Show parse errors in the UI when loading ONC files.

chrome/browser/resources/net_internals/chromeos_view.js

Index: chrome/browser/resources/net_internals/chromeos_view.js
===================================================================
--- chrome/browser/resources/net_internals/chromeos_view.js	(revision 113491)
+++ chrome/browser/resources/net_internals/chromeos_view.js	(working copy)
@@ -20,7 +20,7 @@
     if (fileContent)
       g_browser.importONCFile(fileContent, passcode);
     else
-      setParseStatus_(false);
+      setParseStatus_("ONC file parse failed: file not found");

[kmixter1, 2011/12/10 15:13:09]

Aren't there many possible causes for this, such as the file has the wrong
permissions (I've hit that one).  Also, i18n?

[Charlie Lee, 2011/12/14 17:02:20]

Ok, I made it more general. Also, since net-internals is english only, this is
ok for now.

   }
 
   /**
@@ -69,11 +69,11 @@
    *
    *  @private
    */
-  function setParseStatus_(success) {
+  function setParseStatus_(error) {
     var parseStatus = $(CrosView.PARSE_STATUS_ID);
     parseStatus.hidden = false;
-    parseStatus.textContent = status ?
-        "ONC file successfully parsed" : "ONC file parse failed";
+    parseStatus.textContent = error ?
+        "ONC file parse failed: " + error : "ONC file successfully parsed";

[achuithb, 2011/12/10 01:18:11]

This is going to be a bit weird since error is localized text and you're going
to mix English with other languages when you do this. Can you just do:
parseStatus.textContent = error;
and if there's no error, pass an i18n error string that says "ONC file
successfully parsed"?

[Charlie Lee, 2011/12/14 17:02:20]

Let's fix this for R18. For now, we'll just be ok with mixing languages.

     reset_();
   }