Show parse errors in the UI when loading ONC files.

chrome/browser/chromeos/cros/network_library.h

Index: chrome/browser/chromeos/cros/network_library.h
===================================================================
--- chrome/browser/chromeos/cros/network_library.h	(revision 113491)
+++ chrome/browser/chromeos/cros/network_library.h	(working copy)
@@ -1789,8 +1789,11 @@
   virtual void SwitchToPreferredNetwork() = 0;
 
   // Load networks from an Open Network Configuration blob.
+  // If there was an error, this will return false and |error| will be set to
+  // the error message.
   virtual bool LoadOncNetworks(const std::string& onc_blob,

[achuithb, 2011/12/10 01:18:11]

I don't think anybody cares about the return value any more...

[kmixter1, 2011/12/10 15:13:09]

True, though it's inflexible to have errors returned as localized strings.  I
feel like that's going to be insufficient at some point.  For instance, if we
ever want to start aggregating parse/network errors server side or doing UMA
stats, we'll want to be using enumerators.  (As a side benefit, it would also
simplify unit testing of error handling.)  I'd suggest creating the enum now,
returning that, and creating a OncNetworkParser::GetErrorString(OncErrorCode)
function.

[Charlie Lee, 2011/12/14 17:02:20]

We still use the return value in some cases.

[Charlie Lee, 2011/12/14 17:02:20]

I'd like to keep this for now and fix this for R18.
Would returning the grd constant make sense here?

[kmixter1, 2011/12/14 19:46:38]

Fair enough.  I think the grd constant makes sense.  I would also then suggest
that we return a "imported successfully" constant on success and thus always set
|error|.

[achuithb, 2011/12/14 20:08:03]

+1. Before you return true, perhaps set *error. If it's not possible to do this
for M17 because of grd string limitations, maybe try to do this for M18?

-                               const std::string& passcode) = 0;
+                               const std::string& passcode,
+                               std::string* error) = 0;
 
   // This sets the active network for the network type. Note: priority order
   // is unchanged (i.e. if a wifi network is set to active, but an ethernet