Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/resources/net_internals/chromeos_view.js

Issue 8883046: Show parse errors in the UI when loading ONC files. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/chromeos_view.js
===================================================================
--- chrome/browser/resources/net_internals/chromeos_view.js (revision 114539)
+++ chrome/browser/resources/net_internals/chromeos_view.js (working copy)
@@ -20,7 +20,7 @@
if (fileContent)
g_browser.importONCFile(fileContent, passcode);
else
- setParseStatus_(false);
+ setParseStatus_('ONC file parse failed: cannot read file');
}
/**
@@ -69,11 +69,11 @@
*
* @private
*/
- function setParseStatus_(success) {
+ function setParseStatus_(error) {
var parseStatus = $(CrosView.PARSE_STATUS_ID);
parseStatus.hidden = false;
- parseStatus.textContent = success ?
- "ONC file successfully parsed" : "ONC file parse failed";
+ parseStatus.textContent = error ?
+ 'ONC file parse failed: ' + error : 'ONC file successfully parsed';
reset_();
}
« no previous file with comments | « chrome/browser/resources/net_internals/browser_bridge.js ('k') | chrome/browser/ui/webui/net_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698