Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/policy/network_configuration_updater.cc

Issue 8883046: Show parse errors in the UI when loading ONC files. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/onc_network_parser.cc ('k') | chrome/browser/policy/network_configuration_updater_unittest.cc » ('j') | chrome/browser/resources/net_internals/chromeos_view.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/network_configuration_updater.cc
===================================================================
--- chrome/browser/policy/network_configuration_updater.cc (revision 114479)
+++ chrome/browser/policy/network_configuration_updater.cc (working copy)
@@ -56,8 +56,10 @@
if (*cached_value != new_network_config) {
*cached_value = new_network_config;
- if (!network_library_->LoadOncNetworks(new_network_config, ""))
- LOG(WARNING) << "Network library failed to load ONC configuration.";
+ std::string error;
+ if (!network_library_->LoadOncNetworks(new_network_config, "", &error))
Mattias Nissler (ping if slow) 2011/12/14 22:45:12 you need curlies here.
Charlie Lee 2011/12/14 22:52:02 Done.
+ LOG(WARNING) << "Network library failed to load ONC configuration:"
+ << error;
}
}
« no previous file with comments | « chrome/browser/chromeos/cros/onc_network_parser.cc ('k') | chrome/browser/policy/network_configuration_updater_unittest.cc » ('j') | chrome/browser/resources/net_internals/chromeos_view.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698