Issue 8883042: Added size check for MediaStreamDeviceSettings fake UI.

Issue 8883042: Added size check for MediaStreamDeviceSettings fake UI. (Closed)

Created:
9 years ago by mflodman_chromium_OOO

Modified:
9 years ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added size check for MediaStreamDeviceSettings fake UI. When running the fake ui, behind the media stream flag, there is a missing check for available devices. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114205

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change based on review by wjia. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/renderer_host/media/media_stream_device_settings.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

lgtm after the comment is addressed. http://codereview.chromium.org/8883042/diff/1/content/browser/renderer_host/media/media_stream_device_settings.cc File content/browser/renderer_host/media/media_stream_device_settings.cc (right): http://codereview.chromium.org/8883042/diff/1/content/browser/renderer_host/media/media_stream_device_settings.cc#newcode127 content/browser/renderer_host/media/media_stream_device_settings.cc:127: if (request->devices[kVideoCapture].size() > ...

9 years ago (2011-12-09 15:43:54 UTC) #2

mflodman_chromium_OOO

http://codereview.chromium.org/8883042/diff/1/content/browser/renderer_host/media/media_stream_device_settings.cc File content/browser/renderer_host/media/media_stream_device_settings.cc (right): http://codereview.chromium.org/8883042/diff/1/content/browser/renderer_host/media/media_stream_device_settings.cc#newcode127 content/browser/renderer_host/media/media_stream_device_settings.cc:127: if (request->devices[kVideoCapture].size() > 0 && On 2011/12/09 15:43:54, wjia ...

9 years ago (2011-12-11 16:22:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mflodman@chromium.org/8883042/4001

9 years ago (2011-12-13 09:19:57 UTC) #5

Change committed as 114205

Expand Messages | Collapse Messages