Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 8883038: Don't display the bookmark bar when in fullscreen mode. (Closed)

Created:
9 years ago by jeremya
Modified:
9 years ago
CC:
chromium-reviews, koz (OOO until 15th September)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Don't display the bookmark bar when in fullscreen mode. BUG=105915 TEST=Enable bookmark bar (Ctrl+Shift+B) and enter fullscreen mode. Bookmark bar should not be visible Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jeremya
9 years ago (2011-12-09 00:47:55 UTC) #1
koz (OOO until 15th September)
lgtm
9 years ago (2011-12-09 00:50:34 UTC) #2
sky
LGTM Don't forget that you'll need to merge this over.
9 years ago (2011-12-09 01:22:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8883038/1
9 years ago (2011-12-09 02:12:08 UTC) #4
commit-bot: I haz the power
Try job failure for 8883038-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years ago (2011-12-09 02:48:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8883038/1
9 years ago (2011-12-09 03:16:18 UTC) #6
commit-bot: I haz the power
Try job failure for 8883038-1 (retry) on mac_rel for steps "browser_tests, ui_tests". It's a second ...
9 years ago (2011-12-09 05:12:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8883038/1
9 years ago (2011-12-09 05:16:46 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-09 06:49:15 UTC) #9
Change committed as 113769

Powered by Google App Engine
This is Rietveld 408576698