Making profile avatars and names sync.

Making profile avatars and names sync. This is done by moving these two properties into profile preferences and making them syncable. The profile observes changes to these prefs and pushes them to the profile info cache.

The initialization of these prefs and of the info cache is done in two steps. First, the profile prefs are setup with values generated by the profile info cache. This causes the profile to try to push the changed values to the info cache, but since the profile isn't in the cache, it fails 


BUG=87658
TEST=ProfileManagerTest.InitProfileUserPrefs, Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114263

[jwd, 2011-12-09 19:38:59]

This is a merge of http://codereview.chromium.org/8810001/
http://codereview.chromium.org/8771024/. 8771024 was committed and reverted due
to causing sync integration tests to fail. 8810001 was intended to fix the
problem, but was still failing on mac_sync. They all pass the sync bots now. I
don't know what was wrong with the mac_sync before. Any comments on that?

akalin@, is there anything else I should be doing to make sure I don't mess up
the sync stuff again?

[akalin, 2011-12-09 23:57:28]

On 2011/12/09 19:38:59, Jesse Doherty wrote:
> This is a merge of http://codereview.chromium.org/8810001/
> http://codereview.chromium.org/8771024/. 8771024 was committed and reverted
due
> to causing sync integration tests to fail. 8810001 was intended to fix the
> problem, but was still failing on mac_sync. They all pass the sync bots now. I
> don't know what was wrong with the mac_sync before. Any comments on that?
> 
> akalin@, is there anything else I should be doing to make sure I don't mess up
> the sync stuff again?

The mac_sync failures look like something deep in the bowels of the avatar code.
 I don't know that the sync code has anything to do with except that now that
that pref is synced, once a synced profile is set up it tries to set up an
avatar icon, etc.

But sync stuff LGTM.  I don't see anything obvious that would explain the
failures.

[sail, 2011-12-12 23:09:08]

lgtm

[csilv, 2011-12-12 23:24:01]

lgtm

[commit-bot: I haz the power, 2011-12-13 19:14:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/8883030/2001

[commit-bot: I haz the power, 2011-12-13 20:39:58]

Change committed as 114263