tools/testing/dart/test_suite.dart - Issue 8883017: Split File into File and RandomAccessFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 8883017: Split File into File and RandomAccessFile. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index b45d9b887aeb32ac6ff2dd63d6d9718a1f296a9d..e31be54dd9e2f6a81e5e88faba9e3da542447ca0 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -323,8 +323,7 @@ class StandardTestSuite implements TestSuite {

// Read the entire file into a byte buffer and transform it to a

// String. This will treat the file as ascii but the only parts

// we are interested in will be ascii in any case.

- File file = new File(filename);

- file.openSync();

+ RandomAccessFile file = (new File(filename)).openSync();

List chars = new List(file.lengthSync());

var offset = 0;

while (offset != chars.length) {

« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | utils/markdown/markdown.dart » ('j') | no next file with comments »