Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 8883008: Update the NaCl SDK C example to handle removing module from VarFromUtf8 (Closed)

Created:
9 years ago by dmichael (off chromium)
Modified:
9 years ago
Reviewers:
mball
CC:
chromium-reviews
Visibility:
Public.

Description

Update the NaCl SDK C example to handle removing module from VarFromUtf8 BUG=106596 TEST=NaCl SDK Hello World C example builds and runs successfully. TBR=noelallen1 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113557

Patch Set 1 #

Patch Set 2 : Fix copyright header #

Patch Set 3 : Put copyright header back. Commit-bot hates me #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/examples/hello_world_c/hello_world_c.c View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dmichael (off chromium)
9 years ago (2011-12-08 03:27:18 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-08 03:34:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/8883008/1
9 years ago (2011-12-08 03:37:07 UTC) #3
commit-bot: I haz the power
Presubmit check for 8883008-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-08 03:37:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/8883008/4
9 years ago (2011-12-08 03:48:44 UTC) #5
commit-bot: I haz the power
Presubmit check for 8883008-4 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-08 03:48:45 UTC) #6
mball
9 years ago (2011-12-08 14:48:56 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698