Issue 8883004: Move GetNameValuePairsFromFile -> NameValuePairsParser, ERROR -> WARNING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8883004: Move GetNameValuePairsFromFile -> NameValuePairsParser, ERROR -> WARNING (Closed)

Created:
9 years ago by stevenjb

Modified:
9 years ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move GetNameValuePairsFromFile -> NameValuePairsParser, ERROR -> WARNING BUG=chromium-os:23551 TEST=chrome://system should still have hardware_class successfully filled in; ERROR in issue should only be a warning Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114497

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
M	chrome/browser/chromeos/system/name_value_pairs_parser.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system/name_value_pairs_parser.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/system/statistics_provider.cc	View	1	2 chunks	+7 lines, -20 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8883004/4001

9 years ago (2011-12-14 20:37:12 UTC) #3

Change committed as 114497