Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 8883004: Move GetNameValuePairsFromFile -> NameValuePairsParser, ERROR -> WARNING (Closed)

Created:
9 years ago by stevenjb
Modified:
9 years ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move GetNameValuePairsFromFile -> NameValuePairsParser, ERROR -> WARNING BUG=chromium-os:23551 TEST=chrome://system should still have hardware_class successfully filled in; ERROR in issue should only be a warning Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114497

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M chrome/browser/chromeos/system/name_value_pairs_parser.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/name_value_pairs_parser.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/statistics_provider.cc View 1 2 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
9 years ago (2011-12-08 01:38:31 UTC) #1
satorux1
LGTM
9 years ago (2011-12-12 04:56:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8883004/4001
9 years ago (2011-12-14 20:37:12 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-14 21:56:01 UTC) #4
Change committed as 114497

Powered by Google App Engine
This is Rietveld 408576698