Port GetProcessCount(), KillProcesses(), and CleanupProcesses()....

Port GetProcessCount(), KillProcesses(), and CleanupProcesses().
Also switch to fork() from vfork(), since strace on my box
doesn't support vfork!  It's deprecated, anyway.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4315

[dank, 2008-10-29 18:30:12]

Needed this for net/url_request/url_request_unittest.h.

It's a rough port, good enough for unit tests
but not yet good enough for use in the real browser
(it's used in the Task Manager, for instance)
as it doesn't clean up zombies properly.

[Evan Stade, 2008-10-30 19:10:25]

some style nits

[Evan Stade, 2008-10-30 19:12:49]

http://codereview.chromium.org/8880/diff/7/11
File base/process_util_linux.cc (right):

http://codereview.chromium.org/8880/diff/7/11#newcode13
Line 13: 
is this extra line intentional?

http://codereview.chromium.org/8880/diff/7/11#newcode75
Line 75: while (tries-- > 0) {
nit: why not make this a for loop?

http://codereview.chromium.org/8880/diff/7/11#newcode91
Line 91: executable_name_(executable_name),
I *believe* the standard style for this constructor would be to put the colon on
line 91 with a 4 space indent, align the member declarations with each other (6
spaces over), and give the function body a 2 space indent

http://codereview.chromium.org/8880/diff/7/11#newcode102
Line 102: 
extra line

http://codereview.chromium.org/8880/diff/7/11#newcode110
Line 110: if (result) {
nit: are these braces needed?

http://codereview.chromium.org/8880/diff/7/11#newcode152
Line 152: // To avoid being fooled by names containing a closing paren, scan
backwards.
80 chars (here and below)

http://codereview.chromium.org/8880/diff/7/11#newcode190
Line 190: (!filter_ || filter_->Includes(entry_.pid,
continuation = 4 space indent (when not aligning arguments)

http://codereview.chromium.org/8880/diff/7/11#newcode194
Line 194: 
extra line

http://codereview.chromium.org/8880/diff/7/11#newcode228
Line 228: int end_time = start_time + (wait_milliseconds + 999) / 1000;
I think the TimeDelta class from time.h is preferred for this sort of thing

[agl, 2008-10-30 19:30:18]

http://codereview.chromium.org/8880/diff/7/11
File base/process_util_linux.cc (right):

http://codereview.chromium.org/8880/diff/7/11#newcode71
Line 71: int status = kill(process_id, SIGTERM);
I think you misunderstand signals here. If the signal was sent, status==0. I
think here you actually want:

if (kill(process_id, SIGTERM))
  return false;

if (wait) {

http://codereview.chromium.org/8880/diff/7/11#newcode133
Line 133: if (!isdigit(slot->d_name[0])) {
You should be checking that *all* the elements of the string are digits.

http://codereview.chromium.org/8880/diff/7/11#newcode140
Line 140: sprintf(buf, "/proc/%s/stat", slot->d_name);
snprintf and then buf[NAME_MAX-1] = 0 to force termination

http://codereview.chromium.org/8880/diff/7/11#newcode150
Line 150: // %d %s %s %s ...
%d %s %s %d

[agl, 2008-10-30 20:22:45]

Yep, I'll all happy. LGTM.


AGL