chrome/browser/resources/options/language_options.js - Issue 8879064: Reverting this revert, since it does not seem to have caused the breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 8879064: Reverting this revert, since it does not seem to have caused the breakage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/language_options.html ('k') | chrome/browser/ui/webui/options/language_options_handler_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/language_options.js

===================================================================

--- chrome/browser/resources/options/language_options.js (revision 114404)

+++ chrome/browser/resources/options/language_options.js (working copy)

@@ -93,8 +93,11 @@

$('auto-spell-correction-option').hidden = false;

// Handle spell check enable/disable.

- Preferences.getInstance().addEventListener(this.enableSpellCheckPref,

- this.updateEnableSpellCheck_.bind(this));

+ if (!cr.isMac) {

+ Preferences.getInstance().addEventListener(

+ this.enableSpellCheckPref,

+ this.updateEnableSpellCheck_.bind(this));

+ }

}

// Listen to user clicks on the "Change touch keyboard settings..."

@@ -219,7 +222,8 @@

this.updateSelectedLanguageName_(languageCode);

if (cr.isWindows || cr.isChromeOS)

this.updateUiLanguageButton_(languageCode);

- this.updateSpellCheckLanguageButton_(languageCode);

+ if (!cr.isMac)

+ this.updateSpellCheckLanguageButton_(languageCode);

if (cr.isChromeOS)

this.updateInputMethodList_(languageCode);

this.updateLanguageListInAddLanguageOverlay_();