Aura: Send SetActive IPC to the renderer when focused.

Aura: Send SetActive IPC to the renderer when focused.

TBR=sky@chromium.org
BUG=106897
TEST=cursor appears in a textfield on focus.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113855

[sadrul, 2011-12-09 16:20:07]

Nice!

[Emmanuel Saint-loubert-Bié, 2011-12-09 16:23:01]

Aura specific file that has only Aura side effect. I will LGTM and have sky for
TBR

[commit-bot: I haz the power, 2011-12-09 16:23:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/8879049/1

[oshima, 2011-12-09 16:23:36]

LGTM

Thanks!

- oshima

On Fri, Dec 9, 2011 at 8:20 AM, <sadrul@chromium.org> wrote:

> Nice!
>
>
http://codereview.chromium.**org/8879049/<http://codereview.chromium.org/8879...
>

[sky, 2011-12-09 18:13:23]

LGTM with the following change

http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_aura.cc:477:
host_->SetActive(false);
gtk/win invoke SetActive(false) before Blur. Make this match them.

[commit-bot: I haz the power, 2011-12-09 18:23:47]

Try job failure for 8879049-1 (retry) on mac_rel for step "browser_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-09 18:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/8879049/5002

[varunjain, 2011-12-09 18:42:57]

CQ failed :( Failure seems unrelated though. Re-trying.

http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_aura.cc:477:
host_->SetActive(false);
On 2011/12/09 18:13:23, sky wrote:
> gtk/win invoke SetActive(false) before Blur. Make this match them.

Done.

[varunjain, 2011-12-09 19:03:30]

Turns out these tests are failing on head. I'll submit manually when the tree
becomes green.

On 2011/12/09 18:42:57, varunjain wrote:
> CQ failed :( Failure seems unrelated though. Re-trying.
> 
>
http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
> File content/browser/renderer_host/render_widget_host_view_aura.cc (right):
> 
>
http://codereview.chromium.org/8879049/diff/1/content/browser/renderer_host/r...
> content/browser/renderer_host/render_widget_host_view_aura.cc:477:
> host_->SetActive(false);
> On 2011/12/09 18:13:23, sky wrote:
> > gtk/win invoke SetActive(false) before Blur. Make this match them.
> 
> Done.

[commit-bot: I haz the power, 2011-12-09 20:51:14]

Try job failure for 8879049-5002 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...