[cros] Change Picture prefs page: DOM initialization moved to separate handler from Initialize.

chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

Index: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
index 630118957b8998aca4cd9de0440d8ab0f91f57a9..4e38d3076f8606b2f36c739db948b052d60d5966 100644
--- a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
@@ -73,21 +73,6 @@ ChangePictureOptionsHandler::~ChangePictureOptionsHandler() {
     select_file_dialog_->ListenerDestroyed();
 }
 
-void ChangePictureOptionsHandler::Initialize() {
-  // If no camera presence check has been performed in this session,
-  // start one now.
-  if (CameraDetector::camera_presence() ==
-      CameraDetector::kCameraPresenceUnknown)
-    CheckCameraPresence();
-
-  // While the check is in progress, use previous camera presence state and
-  // presume it is present if no check has been performed yet.
-  SetCameraPresent(CameraDetector::camera_presence() !=
-                   CameraDetector::kCameraAbsent);
-
-  SendAvailableImages();
-}
-
 void ChangePictureOptionsHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
@@ -114,20 +99,23 @@ void ChangePictureOptionsHandler::RegisterMessages() {
   web_ui_->RegisterMessageCallback("takePhoto",
       base::Bind(&ChangePictureOptionsHandler::HandleTakePhoto,
                  base::Unretained(this)));
-  web_ui_->RegisterMessageCallback("onPageShown",
-      base::Bind(&ChangePictureOptionsHandler::HandleOnPageShown,
+  web_ui_->RegisterMessageCallback("onChangePicturePageShown",
+      base::Bind(&ChangePictureOptionsHandler::HandlePageShown,
+                 base::Unretained(this)));
+  web_ui_->RegisterMessageCallback("onChangePicturePageInitialized",
+      base::Bind(&ChangePictureOptionsHandler::HandlePageInitialized,
                  base::Unretained(this)));
   web_ui_->RegisterMessageCallback("selectImage",
       base::Bind(&ChangePictureOptionsHandler::HandleSelectImage,
                  base::Unretained(this)));
 }
 
-void ChangePictureOptionsHandler::SendAvailableImages() {
+void ChangePictureOptionsHandler::SendDefaultImages() {
   ListValue image_urls;
   for (int i = 0; i < kDefaultImagesCount; ++i) {
     image_urls.Append(new StringValue(GetDefaultImageUrl(i)));
   }
-  web_ui_->CallJavascriptFunction("ChangePictureOptions.setUserImages",
+  web_ui_->CallJavascriptFunction("ChangePictureOptions.setDefaultImages",
                                   image_urls);
 }
 
@@ -168,9 +156,30 @@ void ChangePictureOptionsHandler::HandleTakePhoto(const ListValue* args) {
   window->Show();
 }
 
-void ChangePictureOptionsHandler::HandleOnPageShown(
+void ChangePictureOptionsHandler::HandlePageInitialized(
     const base::ListValue* args) {
+  VLOG(1) << "ChangePictureOptionsHandler::HandlePageInitialized";

[James Hawkins, 2011/12/10 04:21:38]

Remove log spam.

[Ivan Korotkov, 2011/12/12 13:47:14]

Done.

+  DCHECK(args && args->empty());
+  // If no camera presence check has been performed in this session,
+  // start one now.
+  if (CameraDetector::camera_presence() ==
+      CameraDetector::kCameraPresenceUnknown)

[James Hawkins, 2011/12/10 04:21:38]

Braces required.

[Ivan Korotkov, 2011/12/12 13:47:14]

Done.

+    CheckCameraPresence();
+
+  // While the check is in progress, use previous camera presence state and
+  // presume it is present if no check has been performed yet.
+  SetCameraPresent(CameraDetector::camera_presence() !=
+                   CameraDetector::kCameraAbsent);
+
+  SendDefaultImages();
+}
+
+void ChangePictureOptionsHandler::HandlePageShown(const base::ListValue* args) {
+  VLOG(1) << "ChangePictureOptionsHandler::HandlePageShown";

[James Hawkins, 2011/12/10 04:21:38]

Remove log spam.

[Ivan Korotkov, 2011/12/12 13:47:14]

Done.

   DCHECK(args && args->empty());
+  // TODO(ivankr): if user opens settings and goes to Change Picture page right

[James Hawkins, 2011/12/10 04:21:38]

nit: Capitalize sentence.

[Ivan Korotkov, 2011/12/12 13:47:14]

Done.

+  // after the check started |HandlePageInitialized| has been completed, we'll

[James Hawkins, 2011/12/10 04:21:38]

nit: Don't use 'we' in comments; it's ambiguous.

[Ivan Korotkov, 2011/12/12 13:47:14]

Done.

+  // call |CheckCameraPresence| twice. Throttle it to prevent excess checks.
   CheckCameraPresence();
   SendSelectedImage();
   UpdateProfileImage();