[cros] Change Picture prefs page: DOM initialization moved to separate handler from Initialize.

[cros] Change Picture prefs page: DOM initialization moved to separate handler from Initialize.

*) Also fixes image grid not loosing focus when closing Change Picture page with the close button.


BUG=chromium-os:23368
TEST=Manual: see bug description; both Backspace and Alt+Left should not trigger the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114015

[Ivan Korotkov, 2011-12-09 10:54:26]

PTAL
jhawkins: resources/options/

[whywhat, 2011-12-09 11:18:14]

lgtm

[James Hawkins, 2011-12-10 04:21:38]

LGTM with nits.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
(right):

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:161:
VLOG(1) << "ChangePictureOptionsHandler::HandlePageInitialized";
Remove log spam.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:166:
CameraDetector::kCameraPresenceUnknown)
Braces required.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:178:
VLOG(1) << "ChangePictureOptionsHandler::HandlePageShown";
Remove log spam.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:180:
// TODO(ivankr): if user opens settings and goes to Change Picture page right
nit: Capitalize sentence.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:181:
// after the check started |HandlePageInitialized| has been completed, we'll
nit: Don't use 'we' in comments; it's ambiguous.

[Ivan Korotkov, 2011-12-12 13:47:14]

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
(right):

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:161:
VLOG(1) << "ChangePictureOptionsHandler::HandlePageInitialized";
On 2011/12/10 04:21:38, James Hawkins wrote:
> Remove log spam.

Done.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:166:
CameraDetector::kCameraPresenceUnknown)
On 2011/12/10 04:21:38, James Hawkins wrote:
> Braces required.

Done.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:178:
VLOG(1) << "ChangePictureOptionsHandler::HandlePageShown";
On 2011/12/10 04:21:38, James Hawkins wrote:
> Remove log spam.

Done.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:180:
// TODO(ivankr): if user opens settings and goes to Change Picture page right
On 2011/12/10 04:21:38, James Hawkins wrote:
> nit: Capitalize sentence.

Done.

http://codereview.chromium.org/8879048/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc:181:
// after the check started |HandlePageInitialized| has been completed, we'll
On 2011/12/10 04:21:38, James Hawkins wrote:
> nit: Don't use 'we' in comments; it's ambiguous.

Done.