Fix crash during profile shutdown

Fix crash during profile shutdown

With multiple profiles we would sometimes crash with the following backtrace:
   ProfileImpl::~ProfileImpl
    ProfileDependencyManager::DestroyProfileServices
      ...
       ProfileImp::InitSyncService()
          UpdateProfileUserNameCache
              profile_manager->GetProfileInfoCache(

The problem was that at this point the profile manager and the profile sync service were both already deleted. Our lazy load of the profile sync service was causing us to create the service twice.

In our other lazy load code we have a flag to prevent us from creating something twice. I added the same code to the profile sync service.

BUG=106869
TEST=Reproduced the crash. Applied my fix and verified that the crash no longer reproduced.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113835

[SteveT, 2011-12-09 15:52:59]

LGTM.

[commit-bot: I haz the power, 2011-12-09 17:44:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8879047/1

[commit-bot: I haz the power, 2011-12-09 19:36:21]

Change committed as 113835