Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: client/dom/scripts/template_frog_dom.darttemplate

Issue 8879044: Work-around Frog codegen bug where Window is derived from native DOMWindow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/scripts/dartgenerator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/template_frog_dom.darttemplate
diff --git a/client/dom/scripts/template_frog_dom.darttemplate b/client/dom/scripts/template_frog_dom.darttemplate
index 4895350c2be11e4fdbd7b7c59dc6c9fbb7b1d60d..241baad60d90c4b9f1a3048ace1476f1ba164e70 100644
--- a/client/dom/scripts/template_frog_dom.darttemplate
+++ b/client/dom/scripts/template_frog_dom.darttemplate
@@ -17,7 +17,10 @@ $!GENERATED_DART_FILES
#source('src/_ListIterators.dart');
#source('src/_Lists.dart');
-class Window extends DOMWindow {}
+// TODO(jmesserly): 'native' here is aWork-around for Frog bug. Frog needs to
+// be smarter about inheriting from a hidden native type (in this case
+// DOMWindow)
+class Window extends DOMWindow native "*Window" {}
DOMWindow get window() native "return window;";
// TODO(vsm): Revert to Dart method when 508 is fixed.
HTMLDocument get document() native "return window.document;";
« no previous file with comments | « client/dom/scripts/dartgenerator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698