Update the extension documentation to explain manifest_version.

Update the extension documentation to explain manifest_version.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113869

[mkearney, 2011-12-08 23:52:22]

Just some small suggestions to improve readability.

Can you send me a link to how this will look live? Sometimes the html view is
tricky to catch the visual stuff.

http://codereview.chromium.org/8879039/diff/1/chrome/common/extensions/docs/s...
File chrome/common/extensions/docs/static/manifest.html (right):

http://codereview.chromium.org/8879039/diff/1/chrome/common/extensions/docs/s...
chrome/common/extensions/docs/static/manifest.html:142: However, the extension
system will prevent you including insecure resources
Suggestion to remove 'however'.

http://codereview.chromium.org/8879039/diff/1/chrome/common/extensions/docs/s...
chrome/common/extensions/docs/static/manifest.html:143: for
<code>script-src</code> or <code>object-src</code>. (If you are using
Suggestion to take this sentence out of parentheses.

http://codereview.chromium.org/8879039/diff/1/chrome/common/extensions/docs/s...
chrome/common/extensions/docs/static/manifest.html:684: A larger number might be
required in the future if there are breaking changes
I think this can be worded better. How about:

Future breaking changes to the extension system may require a new version
number.

[abarth-chromium, 2011-12-09 01:01:49]

On 2011/12/08 23:52:22, mkearney wrote:
> Just some small suggestions to improve readability.

Thanks.

> Can you send me a link to how this will look live? Sometimes the html view is
> tricky to catch the visual stuff.

I'll do that once I get back to my other computer.

> Suggestion to remove 'however'.

Done.

> Suggestion to take this sentence out of parentheses.

Done.

> Future breaking changes to the extension system may require a new version
> number.

Done.

Thanks!

[Aaron Boodman, 2011-12-09 14:59:03]

Don't forget to regenerate the docs.

[abarth-chromium, 2011-12-09 18:46:02]

Now with generated files.

You can see the generated version at
http://www.adambarth.com/experimental/crx/docs/manifest.html

[Aaron Boodman, 2011-12-09 18:49:17]

The manifest_version section shows up twice.

On Fri, Dec 9, 2011 at 10:46 AM,  <abarth@chromium.org> wrote:
> Now with generated files.
>
> You can see the generated version at
> http://www.adambarth.com/experimental/crx/docs/manifest.html
>
> http://codereview.chromium.org/8879039/

[abarth-chromium, 2011-12-09 18:51:26]

On 2011/12/09 18:49:17, Aaron Boodman wrote:
> The manifest_version section shows up twice.

It's just *that* important.  (Will fix.)

[abarth-chromium, 2011-12-09 18:55:14]

Fixenated.

[Aaron Boodman, 2011-12-09 19:48:25]

lgtm

[commit-bot: I haz the power, 2011-12-09 21:07:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/8879039/5003

[commit-bot: I haz the power, 2011-12-09 22:35:36]

Change committed as 113869