Issue 8879035: [windows] Fix checkmark position for WebUI CSS checkbox input elements.

Issue 8879035: [windows] Fix checkmark position for WebUI CSS checkbox input elements. (Closed)

Created:
9 years ago by csilv

Modified:
9 years ago

Reviewers:
dpapad, James Hawkins, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[windows] Fix checkmark position for WebUI CSS checkbox input elements. BUG=105811 TEST=Verify checkboxes render correctly in options window with any font size selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113885

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/shared/css/checkbox.css	View	1	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/8879035/diff/1/chrome/browser/resources/shared/css/checkbox.css File chrome/browser/resources/shared/css/checkbox.css (right): http://codereview.chromium.org/8879035/diff/1/chrome/browser/resources/shared/css/checkbox.css#newcode16 chrome/browser/resources/shared/css/checkbox.css:16: font: inherit; Add the note about the WebKit bug.

9 years ago (2011-12-08 21:53:50 UTC) #2

csilv

9 years ago (2011-12-09 18:25:58 UTC) #3

csilv

+estade for review Evan, asking you to take a look at this one-liner if you ...

9 years ago (2011-12-09 22:44:43 UTC) #4

dpapad

9 years ago (2011-12-12 17:53:20 UTC) #6

http://codereview.chromium.org/8879035/diff/5001/chrome/browser/resources/sha...
File chrome/browser/resources/shared/css/checkbox.css (right):

http://codereview.chromium.org/8879035/diff/5001/chrome/browser/resources/sha...
chrome/browser/resources/shared/css/checkbox.css:17: Windows platform.
http://crbug.com/105811 */
This broke the checkmark position on Linux (see bug 107217). From the comment it
seems that it is only needed for Windows. If so it should be within

html[os='win'] ..... {
  font: inherit;
}

Expand Messages | Collapse Messages