Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 8879032: Removing MessageLoop::QuitTask() from media/ (Closed)

Created:
9 years ago by dcheng
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Removing MessageLoop::QuitTask() from media/ base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113740

Patch Set 1 #

Patch Set 2 : Really fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M media/audio/audio_input_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
9 years ago (2011-12-08 19:52:20 UTC) #1
scherkus (not reviewing)
LGTM
9 years ago (2011-12-08 20:31:38 UTC) #2
dcheng
PTAL, I made a mistake in escaping ()'s the first time.
9 years ago (2011-12-08 20:41:14 UTC) #3
scherkus (not reviewing)
LGTM++
9 years ago (2011-12-08 20:46:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8879032/2001
9 years ago (2011-12-08 20:48:51 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-08 22:13:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8879032/2001
9 years ago (2011-12-08 22:14:34 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-09 02:45:17 UTC) #8
Change committed as 113740

Powered by Google App Engine
This is Rietveld 408576698