Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 8879031: Removing MessageLoop::QuitTask() from net/ (Closed)

Created:
9 years ago by dcheng
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Paweł Hajdan Jr., wtc, darin-cc_chromium.org, rkn, pam+watch_chromium.org, mmenke
Visibility:
Public.

Description

Removing MessageLoop::QuitTask() from net/ base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113713

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M net/base/cookie_monster_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/upgrade.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
9 years ago (2011-12-08 19:53:11 UTC) #1
Randy Smith (Not in Mondays)
LGTM.
9 years ago (2011-12-08 20:06:58 UTC) #2
Randy Smith (Not in Mondays)
On 2011/12/08 20:06:58, rdsmith wrote: > LGTM. Whoops; retracted!! ajwong's comment on another of these ...
9 years ago (2011-12-08 20:09:26 UTC) #3
dcheng
I'm redoing the sed. I did two passes but the escaping for ()'s got messed ...
9 years ago (2011-12-08 20:12:07 UTC) #4
dcheng
PTAL, the escaping has been fixed.
9 years ago (2011-12-08 20:42:48 UTC) #5
Randy Smith (Not in Mondays)
LGTM.
9 years ago (2011-12-08 20:44:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8879031/2004
9 years ago (2011-12-08 20:48:22 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-09 00:34:57 UTC) #8
Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Powered by Google App Engine
This is Rietveld 408576698