Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8879022: retry 113568 - extensions: remove install/uninstall terminology (Closed)

Created:
9 years ago by Evan Stade
Modified:
9 years ago
Reviewers:
Aaron Boodman, sky, Bons
CC:
chromium-reviews, jstritar+watch_chromium.org, jennb, sadrul, ben+watch_chromium.org, prasadt, Dmitry Titov, dcheng, mihaip+watch_chromium.org, jianli, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org, dhollowa+watch_chromium.org
Visibility:
Public.

Description

retry 113568 - extensions: remove install/uninstall terminology replace with add/remove BUG=102610 TEST=manual (for those strings I actually know how to trigger) with fix for aura Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -57 lines) Patch
M chrome/app/generated_resources.grd View 17 chunks +24 lines, -28 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_global_error.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_settings_menu_model.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/aura/app_list_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/permission_warnings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/management/test/basics.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
your rubber stamps are appreciated
9 years ago (2011-12-08 18:01:47 UTC) #1
Aaron Boodman
On 2011/12/08 18:01:47, Evan Stade wrote: > your rubber stamps are appreciated lgtm
9 years ago (2011-12-08 19:41:57 UTC) #2
sky
LGTM
9 years ago (2011-12-08 20:11:48 UTC) #3
Evan Stade
ping andybons
9 years ago (2011-12-09 22:19:05 UTC) #4
Andrew Bonventre
lgtm
9 years ago (2011-12-09 22:40:23 UTC) #5
Evan Stade
thanks Andy. I'll stop bugging you.
9 years ago (2011-12-09 22:45:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8879022/1
9 years ago (2011-12-09 23:05:08 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-10 01:24:19 UTC) #8 
Change committed as 113911

Powered by Google App Engine
This is Rietveld 408576698