Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 8879016: Add more per-tab preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed "migration done" preference Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 url_list->Append(Value::CreateStringValue(example_url0_)); 302 url_list->Append(Value::CreateStringValue(example_url0_));
303 url_list->Append(Value::CreateStringValue(example_url1_)); 303 url_list->Append(Value::CreateStringValue(example_url1_));
304 } 304 }
305 305
306 PreferenceValues cloud_data; 306 PreferenceValues cloud_data;
307 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_); 307 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_);
308 ListValue* urls_to_restore = new ListValue; 308 ListValue* urls_to_restore = new ListValue;
309 urls_to_restore->Append(Value::CreateStringValue(example_url1_)); 309 urls_to_restore->Append(Value::CreateStringValue(example_url1_));
310 urls_to_restore->Append(Value::CreateStringValue(example_url2_)); 310 urls_to_restore->Append(Value::CreateStringValue(example_url2_));
311 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore; 311 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore;
312 cloud_data[prefs::kDefaultCharset] = 312 cloud_data[prefs::kGlobalDefaultCharset] =
313 Value::CreateStringValue(non_default_charset_value_); 313 Value::CreateStringValue(non_default_charset_value_);
314 314
315 AddPreferenceEntriesHelper helper(this, cloud_data); 315 AddPreferenceEntriesHelper helper(this, cloud_data);
316 ASSERT_TRUE(StartSyncService(helper.callback(), false)); 316 ASSERT_TRUE(StartSyncService(helper.callback(), false));
317 ASSERT_TRUE(helper.success()); 317 ASSERT_TRUE(helper.success());
318 318
319 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage)); 319 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage));
320 ASSERT_TRUE(value.get()); 320 ASSERT_TRUE(value.get());
321 std::string string_value; 321 std::string string_value;
322 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 322 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
323 GetAsString(&string_value)); 323 GetAsString(&string_value));
324 EXPECT_EQ(example_url1_, string_value); 324 EXPECT_EQ(example_url1_, string_value);
325 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage)); 325 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage));
326 326
327 scoped_ptr<ListValue> expected_urls(new ListValue); 327 scoped_ptr<ListValue> expected_urls(new ListValue);
328 expected_urls->Append(Value::CreateStringValue(example_url1_)); 328 expected_urls->Append(Value::CreateStringValue(example_url1_));
329 expected_urls->Append(Value::CreateStringValue(example_url2_)); 329 expected_urls->Append(Value::CreateStringValue(example_url2_));
330 expected_urls->Append(Value::CreateStringValue(example_url0_)); 330 expected_urls->Append(Value::CreateStringValue(example_url0_));
331 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup)); 331 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup));
332 ASSERT_TRUE(value.get()); 332 ASSERT_TRUE(value.get());
333 EXPECT_TRUE(value->Equals(expected_urls.get())); 333 EXPECT_TRUE(value->Equals(expected_urls.get()));
334 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup). 334 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup).
335 Equals(expected_urls.get())); 335 Equals(expected_urls.get()));
336 336
337 value.reset(GetSyncedValue(prefs::kDefaultCharset)); 337 value.reset(GetSyncedValue(prefs::kGlobalDefaultCharset));
338 ASSERT_TRUE(value.get()); 338 ASSERT_TRUE(value.get());
339 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 339 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
340 GetAsString(&string_value)); 340 GetAsString(&string_value));
341 EXPECT_EQ(non_default_charset_value_, string_value); 341 EXPECT_EQ(non_default_charset_value_, string_value);
342 EXPECT_EQ(non_default_charset_value_, 342 EXPECT_EQ(non_default_charset_value_,
343 prefs_->GetString(prefs::kDefaultCharset)); 343 prefs_->GetString(prefs::kGlobalDefaultCharset));
344 STLDeleteValues(&cloud_data); 344 STLDeleteValues(&cloud_data);
345 } 345 }
346 346
347 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) { 347 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) {
348 ASSERT_TRUE(StartSyncService(base::Closure(), true)); 348 ASSERT_TRUE(StartSyncService(base::Closure(), true));
349 EXPECT_TRUE(service_->unrecoverable_error_detected()); 349 EXPECT_TRUE(service_->unrecoverable_error_detected());
350 } 350 }
351 351
352 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) { 352 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) {
353 const PrefService::Preference* pref = 353 const PrefService::Preference* pref =
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 EXPECT_FALSE(pref->IsDefaultValue()); 570 EXPECT_FALSE(pref->IsDefaultValue());
571 // There should be no synced value. 571 // There should be no synced value.
572 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 572 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
573 // Switch kHomePage back to unmanaged. 573 // Switch kHomePage back to unmanaged.
574 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage); 574 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage);
575 // The original value should be picked up. 575 // The original value should be picked up.
576 EXPECT_TRUE(pref->IsDefaultValue()); 576 EXPECT_TRUE(pref->IsDefaultValue());
577 // There should still be no synced value. 577 // There should still be no synced value.
578 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 578 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
579 } 579 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698