chrome/browser/prefs/per_tab_user_pref_store.cc - Issue 8879016: Add more per-tab preferences.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/per_tab_user_pref_store.cc

Issue 8879016: Add more per-tab preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed "migration done" preference Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/prefs/per_tab_user_pref_store.h"	5 #include "chrome/browser/prefs/per_tab_user_pref_store.h"

6 #include "chrome/common/pref_names.h"	6 #include "chrome/common/pref_names.h"

7	7

8 PerTabUserPrefStore::PerTabUserPrefStore(PersistentPrefStore* underlay)	8 PerTabUserPrefStore::PerTabUserPrefStore(PersistentPrefStore* underlay)

9 : OverlayUserPrefStore(underlay) {	9 : OverlayUserPrefStore(underlay) {

10 RegisterOverlayProperty(	10 RegisterOverlayProperty(
	Bernhard Bauer 2011/12/22 15:09:01 I don't think we actually need a separate subclass I don't think we actually need a separate subclass here that just registers the overlay properties (why 'property' and not 'pref', BTW?). You could just use a plain OverlayUserPrefStore and call \|RegisterOverlayProperty\| on it. That way we can keep the code in prefs/ independent of the actual set of prefs stored in the overlay.
11 prefs::kWebKitJavascriptEnabled, prefs::kWebKitGlobalJavascriptEnabled);	11 prefs::kWebKitJavascriptEnabled,

	12 prefs::kWebKitGlobalJavascriptEnabled);

	13 RegisterOverlayProperty(

	14 prefs::kWebKitJavascriptCanOpenWindowsAutomatically,

	15 prefs::kWebKitGlobalJavascriptCanOpenWindowsAutomatically);

	16 RegisterOverlayProperty(

	17 prefs::kWebKitLoadsImagesAutomatically,

	18 prefs::kWebKitGlobalLoadsImagesAutomatically);

	19 RegisterOverlayProperty(

	20 prefs::kWebKitPluginsEnabled,

	21 prefs::kWebKitGlobalPluginsEnabled);

	22 RegisterOverlayProperty(

	23 prefs::kDefaultCharset,

	24 prefs::kGlobalDefaultCharset);

	25 RegisterOverlayProperty(

	26 prefs::kWebKitStandardFontFamily,

	27 prefs::kWebKitGlobalStandardFontFamily);

	28 RegisterOverlayProperty(

	29 prefs::kWebKitFixedFontFamily,

	30 prefs::kWebKitGlobalFixedFontFamily);

	31 RegisterOverlayProperty(

	32 prefs::kWebKitSerifFontFamily,

	33 prefs::kWebKitGlobalSerifFontFamily);

	34 RegisterOverlayProperty(

	35 prefs::kWebKitSansSerifFontFamily,

	36 prefs::kWebKitGlobalSansSerifFontFamily);

	37 RegisterOverlayProperty(

	38 prefs::kWebKitCursiveFontFamily,

	39 prefs::kWebKitGlobalCursiveFontFamily);

	40 RegisterOverlayProperty(

	41 prefs::kWebKitFantasyFontFamily,

	42 prefs::kWebKitGlobalFantasyFontFamily);

	43 RegisterOverlayProperty(

	44 prefs::kWebKitDefaultFontSize,

	45 prefs::kWebKitGlobalDefaultFontSize);

	46 RegisterOverlayProperty(

	47 prefs::kWebKitDefaultFixedFontSize,

	48 prefs::kWebKitGlobalDefaultFixedFontSize);

	49 RegisterOverlayProperty(

	50 prefs::kWebKitMinimumFontSize,

	51 prefs::kWebKitGlobalMinimumFontSize);

	52 RegisterOverlayProperty(

	53 prefs::kWebKitMinimumLogicalFontSize,

	54 prefs::kWebKitGlobalMinimumLogicalFontSize);

12 }	55 }

OLD	NEW