chrome/browser/prefs/per_tab_user_pref_store.cc - Issue 8879016: Add more per-tab preferences.

Side by Side Diff: chrome/browser/prefs/per_tab_user_pref_store.cc

Issue 8879016: Add more per-tab preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix browser_tests Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/net/chrome_url_request_context.cc ('K') | « chrome/browser/net/chrome_url_request_context.cc ('k') | chrome/browser/prefs/pref_service_unittest.cc » ('j') | chrome/browser/ui/prefs/prefs_tab_helper_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/prefs/per_tab_user_pref_store.h"	5 #include "chrome/browser/prefs/per_tab_user_pref_store.h"

6 #include "chrome/common/pref_names.h"	6 #include "chrome/common/pref_names.h"

7	7

8 PerTabUserPrefStore::PerTabUserPrefStore(PersistentPrefStore* underlay)	8 PerTabUserPrefStore::PerTabUserPrefStore(PersistentPrefStore* underlay)

9 : OverlayUserPrefStore(underlay) {	9 : OverlayUserPrefStore(underlay) {

10 RegisterOverlayProperty(	10 RegisterOverlayProperty(

11 prefs::kWebKitJavascriptEnabled, prefs::kWebKitGlobalJavascriptEnabled);	11 prefs::kWebKitJavascriptEnabled, prefs::kWebKitGlobalJavascriptEnabled);

	12 RegisterOverlayProperty(

	13 prefs::kWebKitJavascriptCanOpenWindowsAutomatically,

	14 prefs::kWebKitGlobalJavascriptCanOpenWindowsAutomatically);

	15 RegisterOverlayProperty(

	16 prefs::kWebKitLoadsImagesAutomatically,

	17 prefs::kWebKitGlobalLoadsImagesAutomatically);

	18 RegisterOverlayProperty(

	19 prefs::kWebKitPluginsEnabled, prefs::kWebKitGlobalPluginsEnabled);
	Mattias Nissler (ping if slow) 2011/12/09 09:54:44 nit: I'd just make all of these use two lines to g nit: I'd just make all of these use two lines to give the function a consistent look (much easier to scan over for me). Your call. mnaganov (inactive) 2011/12/12 18:19:04 Agree---a consistent layout is easier to parse. Ch Show quoted text On 2011/12/09 09:54:44, Mattias Nissler wrote: > nit: I'd just make all of these use two lines to give the function a consistent > look (much easier to scan over for me). Your call. Agree---a consistent layout is easier to parse. Changed to 3 lines per property.
	20 RegisterOverlayProperty(

	21 prefs::kDefaultCharset, prefs::kGlobalDefaultCharset);

	22 RegisterOverlayProperty(

	23 prefs::kWebKitStandardFontFamily, prefs::kWebKitGlobalStandardFontFamily);

	24 RegisterOverlayProperty(

	25 prefs::kWebKitFixedFontFamily, prefs::kWebKitGlobalFixedFontFamily);

	26 RegisterOverlayProperty(

	27 prefs::kWebKitSerifFontFamily, prefs::kWebKitGlobalSerifFontFamily);

	28 RegisterOverlayProperty(

	29 prefs::kWebKitSansSerifFontFamily,

	30 prefs::kWebKitGlobalSansSerifFontFamily);

	31 RegisterOverlayProperty(

	32 prefs::kWebKitCursiveFontFamily, prefs::kWebKitGlobalCursiveFontFamily);

	33 RegisterOverlayProperty(

	34 prefs::kWebKitFantasyFontFamily, prefs::kWebKitGlobalFantasyFontFamily);

	35 RegisterOverlayProperty(

	36 prefs::kWebKitDefaultFontSize, prefs::kWebKitGlobalDefaultFontSize);

	37 RegisterOverlayProperty(

	38 prefs::kWebKitDefaultFixedFontSize,

	39 prefs::kWebKitGlobalDefaultFixedFontSize);

	40 RegisterOverlayProperty(

	41 prefs::kWebKitMinimumFontSize, prefs::kWebKitGlobalMinimumFontSize);

	42 RegisterOverlayProperty(

	43 prefs::kWebKitMinimumLogicalFontSize,

	44 prefs::kWebKitGlobalMinimumLogicalFontSize);

12 }	45 }

OLD	NEW