Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 8879016: Add more per-tab preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CHECK -> DCHECK Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 url_list->Append(Value::CreateStringValue(example_url0_)); 309 url_list->Append(Value::CreateStringValue(example_url0_));
310 url_list->Append(Value::CreateStringValue(example_url1_)); 310 url_list->Append(Value::CreateStringValue(example_url1_));
311 } 311 }
312 312
313 PreferenceValues cloud_data; 313 PreferenceValues cloud_data;
314 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_); 314 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_);
315 ListValue* urls_to_restore = new ListValue; 315 ListValue* urls_to_restore = new ListValue;
316 urls_to_restore->Append(Value::CreateStringValue(example_url1_)); 316 urls_to_restore->Append(Value::CreateStringValue(example_url1_));
317 urls_to_restore->Append(Value::CreateStringValue(example_url2_)); 317 urls_to_restore->Append(Value::CreateStringValue(example_url2_));
318 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore; 318 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore;
319 cloud_data[prefs::kDefaultCharset] = 319 cloud_data[prefs::kGlobalDefaultCharset] =
320 Value::CreateStringValue(non_default_charset_value_); 320 Value::CreateStringValue(non_default_charset_value_);
321 321
322 AddPreferenceEntriesHelper helper(this, cloud_data); 322 AddPreferenceEntriesHelper helper(this, cloud_data);
323 ASSERT_TRUE(StartSyncService(helper.callback(), false)); 323 ASSERT_TRUE(StartSyncService(helper.callback(), false));
324 ASSERT_TRUE(helper.success()); 324 ASSERT_TRUE(helper.success());
325 325
326 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage)); 326 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage));
327 ASSERT_TRUE(value.get()); 327 ASSERT_TRUE(value.get());
328 std::string string_value; 328 std::string string_value;
329 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 329 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
330 GetAsString(&string_value)); 330 GetAsString(&string_value));
331 EXPECT_EQ(example_url1_, string_value); 331 EXPECT_EQ(example_url1_, string_value);
332 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage)); 332 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage));
333 333
334 scoped_ptr<ListValue> expected_urls(new ListValue); 334 scoped_ptr<ListValue> expected_urls(new ListValue);
335 expected_urls->Append(Value::CreateStringValue(example_url1_)); 335 expected_urls->Append(Value::CreateStringValue(example_url1_));
336 expected_urls->Append(Value::CreateStringValue(example_url2_)); 336 expected_urls->Append(Value::CreateStringValue(example_url2_));
337 expected_urls->Append(Value::CreateStringValue(example_url0_)); 337 expected_urls->Append(Value::CreateStringValue(example_url0_));
338 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup)); 338 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup));
339 ASSERT_TRUE(value.get()); 339 ASSERT_TRUE(value.get());
340 EXPECT_TRUE(value->Equals(expected_urls.get())); 340 EXPECT_TRUE(value->Equals(expected_urls.get()));
341 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup). 341 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup).
342 Equals(expected_urls.get())); 342 Equals(expected_urls.get()));
343 343
344 value.reset(GetSyncedValue(prefs::kDefaultCharset)); 344 value.reset(GetSyncedValue(prefs::kGlobalDefaultCharset));
345 ASSERT_TRUE(value.get()); 345 ASSERT_TRUE(value.get());
346 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 346 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
347 GetAsString(&string_value)); 347 GetAsString(&string_value));
348 EXPECT_EQ(non_default_charset_value_, string_value); 348 EXPECT_EQ(non_default_charset_value_, string_value);
349 EXPECT_EQ(non_default_charset_value_, 349 EXPECT_EQ(non_default_charset_value_,
350 prefs_->GetString(prefs::kDefaultCharset)); 350 prefs_->GetString(prefs::kGlobalDefaultCharset));
351 STLDeleteValues(&cloud_data); 351 STLDeleteValues(&cloud_data);
352 } 352 }
353 353
354 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) { 354 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) {
355 ASSERT_TRUE(StartSyncService(base::Closure(), true)); 355 ASSERT_TRUE(StartSyncService(base::Closure(), true));
356 EXPECT_TRUE(service_->unrecoverable_error_detected()); 356 EXPECT_TRUE(service_->unrecoverable_error_detected());
357 } 357 }
358 358
359 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) { 359 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) {
360 const PrefService::Preference* pref = 360 const PrefService::Preference* pref =
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 EXPECT_FALSE(pref->IsDefaultValue()); 577 EXPECT_FALSE(pref->IsDefaultValue());
578 // There should be no synced value. 578 // There should be no synced value.
579 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 579 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
580 // Switch kHomePage back to unmanaged. 580 // Switch kHomePage back to unmanaged.
581 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage); 581 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage);
582 // The original value should be picked up. 582 // The original value should be picked up.
583 EXPECT_TRUE(pref->IsDefaultValue()); 583 EXPECT_TRUE(pref->IsDefaultValue());
584 // There should still be no synced value. 584 // There should still be no synced value.
585 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 585 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
586 } 586 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698