chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc - Issue 8879015: [cros] Profile image no longer selected when user clicks Take Photo/Choose File buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

Issue 8879015: [cros] Profile image no longer selected when user clicks Take Photo/Choose File buttons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Style-ish fixes. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

index 630118957b8998aca4cd9de0440d8ab0f91f57a9..dc3b56607db5e2ef99f56ba25396738e25a2df6b 100644

--- a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

@@ -233,8 +233,7 @@ void ChangePictureOptionsHandler::HandleSelectImage(const ListValue* args) {

NOTREACHED();

return;

}

- if (image_url.empty())

- return;

+ DCHECK(!image_url.empty());

UserManager* user_manager = UserManager::Get();

const User& user = user_manager->logged_in_user();

« no previous file with comments | « chrome/browser/resources/options/chromeos/change_picture_options.js ('k') | no next file » | no next file with comments »