Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3550)

Unified Diff: chrome/test/data/extensions/api_test/webrequest/test_api.js

Issue 8879011: Make URL filter for web request API mandatory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/webrequest/test_api.js
diff --git a/chrome/test/data/extensions/api_test/webrequest/test_api.js b/chrome/test/data/extensions/api_test/webrequest/test_api.js
index fc54aa34d864e28f7fa21324ac23b1af90754385..4790ab11e6070ec4ddfc0e3827a34cfb1b21c2e9 100644
--- a/chrome/test/data/extensions/api_test/webrequest/test_api.js
+++ b/chrome/test/data/extensions/api_test/webrequest/test_api.js
@@ -5,23 +5,23 @@
chrome.test.runTests([
function addListeners() {
chrome.webRequest.onBeforeRequest.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onBeforeSendHeaders.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onSendHeaders.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onHeadersReceived.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onBeforeRedirect.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onResponseStarted.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onCompleted.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onErrorOccurred.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.webRequest.onAuthRequired.addListener(
- function(details) {});
+ function(details) {}, {urls: ["<all_urls>"]});
chrome.test.succeed();
},
@@ -34,8 +34,8 @@ chrome.test.runTests([
var cb1 = newCallback(1);
var cb2 = newCallback(2);
var event = chrome.webRequest.onBeforeRequest;
- event.addListener(cb1);
- event.addListener(cb2);
+ event.addListener(cb1, {urls: ["<all_urls>"]});
+ event.addListener(cb2, {urls: ["<all_urls>"]});
chrome.test.assertTrue(event.hasListener(cb1));
chrome.test.assertTrue(event.hasListener(cb2));
event.removeListener(cb1);
@@ -60,7 +60,7 @@ chrome.test.runTests([
try {
chrome.webRequest.onBeforeRequest.addListener(
function(details) {},
- {badFilter: 42}, goodExtraInfo);
+ {badFilter: 42, urls: ["<all_urls>"]}, goodExtraInfo);
chrome.test.fail();
} catch (e) {
chrome.test.assertTrue(e.message.search("Invalid value") >= 0);

Powered by Google App Engine
This is Rietveld 408576698