Make URL filter for web request API mandatory

chrome/test/data/extensions/api_test/webrequest/test_blocking.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var pass = chrome.test.callbackPass;
 
 // Constants as functions, not to be called until after runTests.
 function getURLEchoUserAgent() {
   return getServerURL('echoheader?User-Agent');
 }
@@ skipping 44 matching lines @@
             url: getURL("complexLoad/b.html"),
             fromCache: false,
             error: "net::ERR_BLOCKED_BY_CLIENT"
             // Request to chrome-extension:// url has no IP.
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onErrorOccurred"]
       ],
-      {},  // filter
+      {urls: ["<all_urls>"]},  // filter
       ["blocking"]);
     navigateAndWait(getURL("complexLoad/b.html"));
   },
 
   // Navigates to a page with subresources, with a blocking handler that
   // cancels the page request. The page will not load, and we should not
   // see the subresources.
   function simpleLoadCancelledOnReceiveHeaders() {
     expect(
       [  // events
@@ skipping 36 matching lines @@
             fromCache: false,
             error: "net::ERR_BLOCKED_BY_CLIENT"
             // Request to chrome-extension:// url has no IP.
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onErrorOccurred"]
       ],
-      {},  // filter
+      {urls: ["<all_urls>"]},  // filter
       ["blocking"]);
     navigateAndWait(getURLHttpSimpleLoad());
   },
 
   // Navigates to a page with a blocking handler that redirects to a different
   // page.
   // TODO(mpcomplete): We should see an onBeforeRedirect as well, but our
   // process switching logic cancels the original redirect request and
   // starts a new one instead. See http://crbug.com/79520.
   function complexLoadRedirected() {
@@ skipping 41 matching lines @@
             statusCode: 200,
             statusLine: "HTTP/1.1 200 OK",
             // Request to chrome-extension:// url has no IP.
           }
         },
       ],
       [  // event order
         ["onBeforeRequest-1", "onErrorOccurred-1", "onBeforeRequest-2",
          "onResponseStarted", "onCompleted"],
       ],
-      {}, // filter
+      {urls: ["<all_urls>"]}, // filter
       ["blocking"]);
     navigateAndWait(getURL("complexLoad/a.html"));
   },
 
   // Loads a testserver page that echoes the User-Agent header that was
   // sent to fetch it. We modify the outgoing User-Agent in
   // onBeforeSendHeaders, so we should see that modified version.
   function modifyRequestHeaders() {
     expect(
       [  // events
@@ skipping 43 matching lines @@
             statusCode: 200,
             ip: "127.0.0.1",
             statusLine: "HTTP/1.0 200 OK",
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
-      {}, ["blocking"]);
+      {urls: ["<all_urls>"]}, ["blocking"]);
     // Check the page content for our modified User-Agent string.
     navigateAndWait(getURLEchoUserAgent(), function() {
       chrome.test.listenOnce(chrome.extension.onRequest, function(request) {
         chrome.test.assertTrue(request.pass, "Request header was not set.");
       });
       chrome.tabs.executeScript(tabId,
         {
           code: "chrome.extension.sendRequest(" +
               "{pass: document.body.innerText.indexOf('FoobarUA') >= 0});"
         });
@@ skipping 54 matching lines @@
             statusCode: 200,
             ip: "127.0.0.1",
             statusLine: "HTTP/1.0 200 OK",
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
-      {}, ["blocking"]);
+      {urls: ["<all_urls>"]}, ["blocking"]);
     // Check the page content for our modified User-Agent string.
     navigateAndWait(getURLEchoUserAgent(), function() {
       chrome.test.listenOnce(chrome.extension.onRequest, function(request) {
         chrome.test.assertTrue(request.pass, "Request header was not set.");
       });
       chrome.tabs.executeScript(tabId,
         {
           code: "chrome.extension.sendRequest(" +
               "{pass: document.body.innerText.indexOf('FoobarUA') >= 0});"
         });
@@ skipping 69 matching lines @@
             statusLine: "HTTP/1.0 200 OK",
             ip: "127.0.0.1",
             responseHeadersExist: true,
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
-      {}, ["blocking", "responseHeaders"]);
+      {urls: ["<all_urls>"]}, ["blocking", "responseHeaders"]);
     // Check that the cookie was really removed.
     navigateAndWait(getURLSetCookie(), function() {
       chrome.test.listenOnce(chrome.extension.onRequest, function(request) {
         chrome.test.assertTrue(request.pass, "Cookie was not removed.");
       });
       chrome.tabs.executeScript(tabId,
       { code: "chrome.extension.sendRequest(" +
             "{pass: document.cookie.indexOf('Foo') == -1});"
         });
     });
@@ skipping 77 matching lines @@
             statusLine: "HTTP/1.0 200 OK",
             ip: "127.0.0.1",
             responseHeadersExist: true,
           }
         },
       ],
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
-      {}, ["blocking", "responseHeaders"]);
+      {urls: ["<all_urls>"]}, ["blocking", "responseHeaders"]);
     // Check that the cookie was really removed.
     navigateAndWait(getURLNonUTF8SetCookie(), function() {
       chrome.test.listenOnce(chrome.extension.onRequest, function(request) {
         chrome.test.assertTrue(request.pass, "Cookie was not removed.");
       });
       chrome.tabs.executeScript(tabId,
       { code: "chrome.extension.sendRequest(" +
             "{pass: document.cookie.indexOf('Foo') == -1});"
         });
     });
@@ skipping 92 matching lines @@
             statusLine: "HTTP/1.1 200 OK",
             // Request to chrome-extension:// url has no IP.
           }
         },
       ],
       [  // event order
         ["a-onBeforeRequest", "a-onResponseStarted", "a-onCompleted",
          "x-onSendHeaders", "x-onResponseStarted", "x-onCompleted",
          "b-onBeforeRequest", "b-onResponseStarted", "b-onCompleted"]
       ],
-      {}, ["blocking"]);
+      {urls: ["<all_urls>"]}, ["blocking"]);
     // Check the page content for our modified User-Agent string.
     navigateAndWait(getURL("simpleLoad/a.html"), function() {
         var req = new XMLHttpRequest();
         var asynchronous = false;
         req.open("GET", getURLHttpXHRData(), asynchronous);
         req.send(null);
         navigateAndWait(getURL("complexLoad/b.jpg"));
     });
   },
 ]);