Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 8879010: Increase eval compilation cache hits.

Created:
9 years ago by Steven
Modified:
9 years ago
CC:
v8-dev
Visibility:
Public.

Description

Increase eval compilation cache hits. This CL introduces two changes to the eval compilation cache. Firstly, instead of checking for SharedFunctionInfo equivalence to ensure equivalence of direct eval call sites we now check for Script and scope start position equivalence. Furthermore, we increase the cache hits by allowing to share global eval code for direct and indirect call sites, e.g. in the case var x = eval; x("12"); eval("12"); BUG=v8:1854 TEST=existing tests in mjsunit

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/compilation-cache.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Steven
9 years ago (2011-12-08 10:00:19 UTC) #1
PTAL.

Powered by Google App Engine
This is Rietveld 408576698