Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: frog/minfrog

Issue 8879006: frog: detect when getter/setter has incorrect number of arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/minfrog
diff --git a/frog/minfrog b/frog/minfrog
index f196e81f6558a9aca27a58749fd8d03ef5bc1114..50c0ef7002bf6e6ed220963d63d7caca467d7c53 100755
--- a/frog/minfrog
+++ b/frog/minfrog
@@ -5023,8 +5023,18 @@ PropertyMember.prototype.addFromParent = function(parentMember) {
if (this.setter == null) this.setter = parent.setter;
}
PropertyMember.prototype.resolve = function() {
- if (this.getter != null) this.getter.resolve();
- if (this.setter != null) this.setter.resolve();
+ if (this.getter != null) {
+ this.getter.resolve();
+ if (this.getter.parameters.length != 0) {
+ $globals.world.error('getter methods should take no arguments', this.getter.definition.span);
+ }
+ }
+ if (this.setter != null) {
+ this.setter.resolve();
+ if (this.setter.parameters.length != 1) {
+ $globals.world.error('setter methods should take a single argument', this.setter.definition.span);
+ }
+ }
this.get$library()._addMember(this);
}
PropertyMember.prototype._get$3 = function($0, $1, $2) {

Powered by Google App Engine
This is Rietveld 408576698