Fix bug where panels sometimes don't align on bottom.

Fix bug where panels sometimes don't align on bottom.

This happens when a move animation starts while a resize animation, typically during creation is in progress. Now the animation starts from where the last one left.

Fixes a bug where from bounds and to bounds are reversed in the called StartBoundsAnimation in OnSizeChanged.

BUG=106573
TEST=Instructions in bug report.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113746

[Dmitry Titov, 2011-12-08 19:04:45]

You want to sync with 3-step before landing because it touched the same ecode..

Also, 2 questions:

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.cc (right):

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:417: if
(bounds_animator_.get() && bounds_animator_->IsShowing()) {
should it be is_animating()? I think IsShowing() is false when the animation is
'closing'.

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:419:
bounds_animator_->Reset();
Reset() says it goes back to 0, will it eventually trigger a visual glitch when
it snaps all the way back to start bounds, and then abruptly continue from
last_animation_progressed_bounds_?

[prasadt, 2011-12-08 21:41:45]

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_window_gtk.cc (right):

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:417: if
(bounds_animator_.get() && bounds_animator_->IsShowing()) {
On 2011/12/08 19:04:45, Dmitry Titov wrote:
> should it be is_animating()? I think IsShowing() is false when the animation
is
> 'closing'.

Done.

http://codereview.chromium.org/8879005/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_window_gtk.cc:419:
bounds_animator_->Reset();
On 2011/12/08 19:04:45, Dmitry Titov wrote:
> Reset() says it goes back to 0, will it eventually trigger a visual glitch
when
> it snaps all the way back to start bounds, and then abruptly continue from
> last_animation_progressed_bounds_?

Done. That line doesn't exist after merging with latest.

[prasadt, 2011-12-08 21:43:10]

Also fixed the issue with from/to bounds being reversed in
StartBoundsAnimation() call in OnSizeAvailable().

[Dmitry Titov, 2011-12-08 21:45:13]

lgtm

[commit-bot: I haz the power, 2011-12-08 21:51:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prasadt@chromium.org/8879005/2002

[commit-bot: I haz the power, 2011-12-09 01:07:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prasadt@chromium.org/8879005/5002

[commit-bot: I haz the power, 2011-12-09 03:37:09]

Change committed as 113746