Issue 8879001: Added about:os-credits to content security policy exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8879001: Added about:os-credits to content security policy exceptions (Closed)

Created:
9 years ago by zel

Modified:
9 years ago

Reviewers:
Tom Sepez, Daniel Erat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Added about:os-credits to content security policy exception set. BUG=chromium-os:23898 TEST=load about:os-credits, make sure license info shows when you click on 'show license' link

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/webui/chrome_url_data_manager_backend.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zel

I hate adding to the list from which we should be removing items from, but ...

9 years ago (2011-12-08 00:41:21 UTC) #1

Daniel Erat

9 years ago (2011-12-08 00:46:52 UTC) #2

lgtm

http://codereview.chromium.org/8879001/diff/1/chrome/browser/ui/webui/chrome_...
File chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (right):

http://codereview.chromium.org/8879001/diff/1/chrome/browser/ui/webui/chrome_...
chrome/browser/ui/webui/chrome_url_data_manager_backend.cc:73:
insert(chrome::kChromeUIOSCreditsHost);
nit: mind alphabetizing the list?  (OobeHost is also out of place)

Expand Messages | Collapse Messages