content/common/gpu/gpu_channel_manager.cc - Issue 8877001: Add more CHECK in GPU and NPAPI process on invalid file descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_channel_manager.cc

Issue 8877001: Add more CHECK in GPU and NPAPI process on invalid file descriptors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Also add check in NPChannelBase::Init in ServerMode. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/gpu_channel_manager.cc

diff --git a/content/common/gpu/gpu_channel_manager.cc b/content/common/gpu/gpu_channel_manager.cc

index cacb7eb61b815cf4b903f543d8af5134e34af5d2..53dbeb0fd4a6e379ef89400a3afedf432b59f9b8 100644

--- a/content/common/gpu/gpu_channel_manager.cc

+++ b/content/common/gpu/gpu_channel_manager.cc

@@ -79,8 +79,10 @@ void GpuChannelManager::OnEstablishChannel(int renderer_id) {

GpuChannelMap::const_iterator iter = gpu_channels_.find(renderer_id);

if (iter == gpu_channels_.end())

channel = new GpuChannel(this, watchdog_, renderer_id, false);

- else

+ else {

piman 2011/12/08 07:09:11 nit: braces on both sides of the else.

xhwang 2011/12/08 19:37:49 Done.

+ NOTREACHED();

channel = iter->second;

+ }

DCHECK(channel != NULL);

« content/common/gpu/gpu_channel.cc ('K') | « content/common/gpu/gpu_channel.cc ('k') | content/common/np_channel_base.cc » ('j') | no next file with comments »