Add more CHECK in GPU and NPAPI process on invalid file descriptors

content/common/np_channel_base.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/np_channel_base.h"
 
 #include <stack>
 
 #include "base/auto_reset.h"
 #include "base/hash_tables.h"
@@ skipping 113 matching lines @@
 #if defined(OS_POSIX)
   // Check the validity of fd for bug investigation.  Remove after fixed.
   // See for details: crbug.com/95129, crbug.com/97285.
   if (mode_ == IPC::Channel::MODE_CLIENT)
     CHECK_NE(-1, channel_handle_.socket.fd);
 #endif
 
   channel_.reset(new IPC::SyncChannel(
       channel_handle_, mode_, this, ipc_message_loop, create_pipe_now,
       shutdown_event));
+
+#if defined(OS_POSIX)
+  // Check the validity of fd for bug investigation.  Remove after fixed.
+  // See for details: crbug.com/95129, crbug.com/97285.
+  if (mode_ == IPC::Channel::MODE_SERVER)

[ddorwin, 2011/12/08 19:17:27]

Do we have a separate check that covers the client case or otherwise know that
it's no the client case that's causing a problem?

[xhwang, 2011/12/08 19:37:49]

This same function is shared by both server and client sides.  Line 124-129
covers the check in the client case.

+    CHECK_NE(-1, channel_->GetClientFileDescriptor());
+#endif
+
   channel_valid_ = true;
   return true;
 }
 
 bool NPChannelBase::Send(IPC::Message* message) {
   if (!channel_.get()) {
     delete message;
     return false;
   }
 
@@ skipping 133 matching lines @@
 
 void NPChannelBase::RemoveMappingForNPObjectStub(int route_id,
                                                  NPObject* object) {
   DCHECK(object != NULL);
   stub_map_.erase(object);
 }
 
 void NPChannelBase::RemoveMappingForNPObjectProxy(int route_id) {
   proxy_map_.erase(route_id);
 }