Issue 8876001: Call NotifyObservers() after setting sync setup completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8876001: Call NotifyObservers() after setting sync setup completed. (Closed)

Created:
9 years ago by stevenjb

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow), tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Call NotifyObservers() after setting sync setup completed. The UI behavior changes once HasSyncSetupCompleted() returns true, so we need to notify observers when we set this in OnBackendInitialized(). BUG=chromium-os:23151 TEST=See issue. Also make sure error clears correctly and is set correctly for other sync errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113643

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/sync/profile_sync_service.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

After discussing this with Andrew + further investigation I discovered that we are eventually calling ...

9 years ago (2011-12-08 00:24:23 UTC) #1

LGTM

Expand Messages | Collapse Messages