Issue 8875: Fix Chromium issue 3607....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8875: Fix Chromium issue 3607.... (Closed)

Created:
12 years, 1 month ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix Chromium issue 3607. Make Date::toLocaleDateString output be the same format as Safari. Someone famililar with Date builtin object should check other functions. Committed: http://code.google.com/p/v8/source/detail?r=645

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	src/date-delay.js	View		3 chunks	+16 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 1 month ago (2008-10-29 22:59:38 UTC) #2

LGTMForNow

I am OK with this change for "Mstone-1.0" only to make it look more like Safari
on Windows: It appears that Safari 3.1.2 on Windows does not honor the local
machine setting for the Date formatting. Safari 3.1.2 on the Mac does change the
output based on the system preference.

We should mark the fact that this is a quick hack in the bug and assign the bug
to somebody knowledgeable about date formatting to fix the real "I18N" issue.

-Ivan

http://codereview.chromium.org/8875/diff/1/2
File src/date-delay.js (right):

http://codereview.chromium.org/8875/diff/1/2#newcode504
Line 504: 
missing new line?

Expand Messages | Collapse Messages