Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 8873056: Fix UserActionsMetrics calls for content settings UMA (Closed)

Created:
9 years ago by markusheintz_
Modified:
9 years ago
Reviewers:
battre
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix UserActionsMetrics calls for content settings UMA, so that they get picked up by the the chrome/tools/extract_actions.py tool. Remove wrong and unused user action metrics hash and add the correct hashes. BUG=105865 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113798

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 2 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
markusheintz_
Please review my CL. Thanks
9 years ago (2011-12-09 11:54:42 UTC) #1
battre
lgtm
9 years ago (2011-12-09 12:02:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/8873056/3001
9 years ago (2011-12-09 12:18:40 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-09 14:39:37 UTC) #4
Change committed as 113798

Powered by Google App Engine
This is Rietveld 408576698