[debugger] noRefs option for fixing blowing array refs

src/debug-debugger.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1331 matching lines @@
         if (this.body[i] instanceof Mirror) {
           bodyJson.push(serializer.serializeValue(this.body[i]));
         } else {
           bodyJson.push(ObjectToProtocolObject_(this.body[i], serializer));
         }
       }
     } else {
       bodyJson = ObjectToProtocolObject_(this.body, serializer);
     }
     json.body = bodyJson;
-    json.refs = serializer.serializeReferencedObjects();
+    if (!this.options_ || !this.options_.noRefs) {

[Peter Rybin, 2011/12/14 12:22:22]

What happens if you use includeRefs options here instead of introducing your
own? Have you tried it?
In your client you set protocol argument "includeRefs": false
Will this work?

[indutny, 2011/12/14 12:33:08]

You mean includeRefs: true, right?

Looks like this works for me, you can close this CL, thanks!

[Peter Rybin, 2011/12/14 18:13:55]

Your change allows user to reject "refs" from the response. I meant that you
could keep it, but try to re-use already existing option called "includeRefs"
instead of introducing your own.

However if the old options already fully works for you it's cool.

+      json.refs = serializer.serializeReferencedObjects();
+    }
   }
   if (this.message) {
     json.message = this.message;
   }
   json.running = this.running;
   return JSON.stringify(json);
 };
 
 
 DebugCommandProcessor.prototype.createResponse = function(request) {
@@ skipping 25 matching lines @@
         throw new Error('Command not specified');
       }
 
       if (request.arguments) {
         var args = request.arguments;
         // TODO(yurys): remove request.arguments.compactFormat check once
         // ChromeDevTools are switched to 'inlineRefs'
         if (args.inlineRefs || args.compactFormat) {
           response.setOption('inlineRefs', true);
         }
+        if (args.noRefs) {
+          response.setOption('noRefs', true);
+        }
         if (!IS_UNDEFINED(args.maxStringLength)) {
           response.setOption('maxStringLength', args.maxStringLength);
         }
       }
 
       if (request.command == 'continue') {
         this.continueRequest_(request, response);
       } else if (request.command == 'break') {
         this.breakRequest_(request, response);
       } else if (request.command == 'setbreakpoint') {
@@ skipping 1198 matching lines @@
     case 'string':
     case 'number':
       json = value;
       break;
 
     default:
       json = null;
   }
   return json;
 }