Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/browser/browser_focus_uitest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_focus_uitest.cc
diff --git a/chrome/browser/browser_focus_uitest.cc b/chrome/browser/browser_focus_uitest.cc
index f777b6f7436a260ff8c46122492ce10320c73a99..c38c90b9b5c5aab98206aafb37df56414fb38043 100644
--- a/chrome/browser/browser_focus_uitest.cc
+++ b/chrome/browser/browser_focus_uitest.cc
@@ -190,7 +190,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, ClickingMovesFocus) {
// It seems we have to wait a little bit for the widgets to spin up before
// we can start clicking on them.
MessageLoop::current()->PostDelayedTask(FROM_HERE,
- new MessageLoop::QuitTask(),
+ MessageLoop::QuitClosure(),
kActionDelayMs);
ui_test_utils::RunMessageLoop();
#endif // defined(OS_POSIX)
@@ -591,7 +591,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, MAYBE_FocusTraversalOnInterstitial) {
interstitial_page->Show();
// Give some time for the interstitial to show.
MessageLoop::current()->PostDelayedTask(FROM_HERE,
- new MessageLoop::QuitTask(),
+ MessageLoop::QuitClosure(),
1000);
ui_test_utils::RunMessageLoop();
@@ -717,7 +717,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, InterstitialFocus) {
interstitial_page->Show();
// Give some time for the interstitial to show.
MessageLoop::current()->PostDelayedTask(FROM_HERE,
- new MessageLoop::QuitTask(),
+ MessageLoop::QuitClosure(),
1000);
ui_test_utils::RunMessageLoop();
@@ -765,7 +765,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, FindFocusTest) {
// - creating a factory used to create the delegate
// - making the test a private and overwriting the delegate member directly.
MessageLoop::current()->PostDelayedTask(
- FROM_HERE, new MessageLoop::QuitTask(), kActionDelayMs);
+ FROM_HERE, MessageLoop::QuitClosure(), kActionDelayMs);
ui_test_utils::RunMessageLoop();
ASSERT_TRUE(IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
@@ -798,7 +798,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, FindFocusTest) {
// See remark above on why we wait.
MessageLoop::current()->PostDelayedTask(
- FROM_HERE, new MessageLoop::QuitTask(), kActionDelayMs);
+ FROM_HERE, MessageLoop::QuitClosure(), kActionDelayMs);
ui_test_utils::RunMessageLoop();
ASSERT_TRUE(IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
}

Powered by Google App Engine
This is Rietveld 408576698