Lower log level for profile errors

Lower log level for profile errors

The GAIA profile downloader code was causing log spew for tests.

I tried to disable the logging for test code but I couldn't figure out how to do it so I'm just lowering the log level instead.

BUG=106783
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113876

[Ivan Korotkov, 2011-12-08 19:48:22]

lgtm

[commit-bot: I haz the power, 2011-12-08 19:48:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8873028/1

[akalin, 2011-12-08 19:49:50]

Does this change anything? Any non-vlog will still cause log spew
On Dec 8, 2011 11:44 AM, <sail@chromium.org> wrote:

> Reviewers: Ivan Korotkov, akalin,
>
> Description:
> Lower log level for profile errors
>
> The GAIA profile downloader code was causing log spew for tests.
>
> I tried to disable the logging for test code but I couldn't figure out how
> to do
> it so I'm just lowering the log level instead.
>
> BUG=106783
> TEST=
>
>
> Please review this at
http://codereview.chromium.**org/8873028/<http://codereview.chromium.org/8873...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/profiles/**profile_downloader.cc
>
>
> Index: chrome/browser/profiles/**profile_downloader.cc
> diff --git a/chrome/browser/profiles/**profile_downloader.cc
> b/chrome/browser/profiles/**profile_downloader.cc
> index 8e0522b6d034c9641dcd13f99837bc**46055a5a70..**
> 1dde9904d50b435ea663dc9a98e7ed**46e8d44efb 100644
> --- a/chrome/browser/profiles/**profile_downloader.cc
> +++ b/chrome/browser/profiles/**profile_downloader.cc
> @@ -273,9 +273,9 @@ void ProfileDownloader::**OnURLFetchComplete(const
> content::URLFetcher* source) {
>   std::string data;
>   source->GetResponseAsString(&**data);
>   if (source->GetResponseCode() != 200) {
> -    LOG(ERROR) << "Response code is " << source->GetResponseCode();
> -    LOG(ERROR) << "Url is " << source->GetURL().spec();
> -    LOG(ERROR) << "Data is " << data;
> +    LOG(WARNING) << "Response code is " << source->GetResponseCode();
> +    LOG(WARNING) << "Url is " << source->GetURL().spec();
> +    LOG(WARNING) << "Data is " << data;
>     delegate_->OnDownloadComplete(**this, false);
>     return;
>   }
>
>
>

[sail, 2011-12-08 20:02:07]

On 2011/12/08 19:49:50, akalin wrote:
> Does this change anything? Any non-vlog will still cause log spew

Are the test being run in debug or release mode? In release LOG(WARNING) doesn't
show up.

[akalin, 2011-12-09 18:44:21]

On 2011/12/08 20:02:07, sail wrote:
> On 2011/12/08 19:49:50, akalin wrote:
> > Does this change anything? Any non-vlog will still cause log spew
> 
> Are the test being run in debug or release mode? In release LOG(WARNING)
doesn't
> show up.

Right, debug mode.  Surely 99% of developers who run a test that hits the
profile downloader don't care about the log messages?  I suggest using DVLOG(1)
-- then turning on the logging is simply --vmodule=profile_downloader=1.

[akalin, 2011-12-09 21:14:14]

On 2011/12/09 18:51:47, sail wrote:

LGTM

thanks!!

[commit-bot: I haz the power, 2011-12-09 21:16:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8873028/7001

[commit-bot: I haz the power, 2011-12-09 23:07:42]

Change committed as 113876