Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 8873021: (Base)SessionService: Remove dead code which was only used by the unit tests. (Closed)

Created:
9 years ago by marja
Modified:
9 years ago
Reviewers:
Nicolas Zea, albertb
CC:
chromium-reviews, Paweł Hajdan Jr., Nicolas Zea
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

(Base)SessionService: Remove dead code which was only used by the unit tests. BUG=NONE TEST=builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114201

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -91 lines) Patch
M chrome/browser/sessions/base_session_service.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 chunks +1 line, -30 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
Hi, This CL removes the dead code I asked about last week. Does this make ...
9 years ago (2011-12-12 10:44:47 UTC) #1
Nicolas Zea
LGTM (Albert no longer works on on the Chromium client code, so reviewing in his ...
9 years ago (2011-12-12 18:52:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8873021/2001
9 years ago (2011-12-13 08:33:32 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 09:56:01 UTC) #4
Change committed as 114201

Powered by Google App Engine
This is Rietveld 408576698