Issue 8873015: Revert 113591 - Revert 113579 - Content settings: allow scripts on interstitial pages even if Jav...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8873015: Revert 113591 - Revert 113579 - Content settings: allow scripts on interstitial pages even if Jav... (Closed)

Created:
9 years ago by dgozman

Modified:
9 years ago

Reviewers:
dgozman

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ajwong+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113591 - Revert 113579 - Content settings: allow scripts on interstitial pages even if JavaScript is blocked. BUG=104700 TEST=ChromeRenderViewTest.ContentSettingsInterstitialPages Review URL: http://codereview.chromium.org/8773035 TBR=marja@chromium.org Review URL: http://codereview.chromium.org/8889008 TBR=dgozman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113594

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -1 line)			Patch
M	chrome/browser/tab_contents/chrome_interstitial_page.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View	5 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/renderer/content_settings_observer_browsertest.cc	View	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages